Test Results

 3 015 files  ±0   3 015 suites  ±0   2h 8m 24s ⏱️ - 7m 54s
 8 258 tests ±0   8 009 ✅  - 1  248 💤 ±0  1 ❌ +1 
23 598 runs  ±0  22 806 ✅  - 1  791 💤 ±0  1 ❌ +1 

For more details on these failures, see this check.

Results for commit 12a6159. ± Comparison against base commit 764a0b7.

♻️ This comment has been updated with latest results.

@deepika-u Have you looked into what would cause to not use this method in console? It is what I would rather see be done rather than this push/revert.

@akurtakov
Instead of calling the deprecated getVisibleLinesInViewport method, the line count can be computed inline within the caller, as I have access to the fTextWidget object. However, the limitation noted in the deprecation still applies - results may be inaccurate when the widget uses variable line heights. I will continue investigating potential approaches. Do you have any suggestions on how this could be achieved?

I haven't found the time to look into it at all. It's the general approach how things should happen in this case that I pointed out.

Is this change still relevant?

@vogella
From my further investigation, there is no replacement yet for getVisibleLinesInViewport() so better remove the deprecation details is a meaningful way to proceed till we have the equivalent ready.

Thanks for checking.